search

e2fyi / kubeflow-aws

Kustomize manifest to deploy kubeflow pipelines in AWS
Apache License 2.0
21 stars 9 forks source link

Do not allow service port to be mutated - fix #18 #19

Closed eterna2 closed 4 years ago

eterna2 commented 4 years ago

This PR remove the permission to modify service/ports/port to fix #18 

when I run the command .
kubectl kustomize overlay/${VARIANT} > kubeflow-pipelines-aws.yaml

I got the config merge issue.

I1027 20:05:10.994651 40204 log.go:172] well-defined vars that were never replaced: mlmdDb,pipelinePath,awsIAMAnnotationKey,dbHost,dbPort,kfp-app-name,kfp-app-version,artifactRepositoryKeyPrefix,groupConcatMaxLen,kfp-namespace,mysqlStorageType,cacheDb,kfp-container-runtime-executor,mysqlPvcName,mysqlStorageSize,pipelineDb,artifactRepositoryBucket,awsIAMRole,awsRegion,kfp-artifact-bucket-name,mysqlStorageClass
Error: 80 is expected to be string

@lzuwei can u double check if we modify service port in our kustomize configs?

Cuz it seems to cuz error, see

lzuwei commented 4 years ago

From the codes, we don't modify service ports right now. I think it is safe to remove.