search

e2nIEE / pandapipes

A pipeflow calculation tool that complements pandapower in the simulation of multi energy grids
https://www.pandapipes.org
Other
147 stars 62 forks source link

pipeflow cancellation if all nodes are out-of-service after the connectivity check #564

Closed SimonRubenDrauz closed 10 months ago

codecov[bot] commented 1 year ago

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (d5d25ae) 85.12% compared to head (a15399c) 85.13%.

Files Patch % Lines
pandapipes/pipeflow.py 85.71% 1 Missing :warning:
setup.py 0.00% 1 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## develop #564 +/- ## ======================================== Coverage 85.12% 85.13% ======================================== Files 90 90 Lines 6179 6181 +2 ======================================== + Hits 5260 5262 +2 Misses 919 919 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

SimonRubenDrauz commented 1 year ago

Right now, what happens is, that it just returns wihtout raising any error. This means that the pipeflow can be conducted even in an empty or non-supplied net. The results would be nans for all nodes, pipes and so on. I prefer this solution as it is consistent if only a certain part of the net is not supplied. By default calling the pipeflow, net.converged is set False by default. Shall we set it to True or leave it False here? I would add it to the test accordingly!

SimonRubenDrauz commented 11 months ago

@dlohmeier: any new thoughts on this?

SimonRubenDrauz commented 10 months ago

changed fork branch. Please refer to #579

SimonRubenDrauz commented 10 months ago

changed fork branch. Please refer to https://github.com/e2nIEE/pandapipes/pull/579