e2nIEE / pandapipes

A pipeflow calculation tool that complements pandapower in the simulation of multi energy grids
https://www.pandapipes.org
Other
139 stars 60 forks source link

Props norm #597

Closed SimonRubenDrauz closed 5 months ago

codecov[bot] commented 6 months ago

Codecov Report

Attention: Patch coverage is 99.00881% with 9 lines in your changes are missing coverage. Please review.

Project coverage is 90.84%. Comparing base (9385283) to head (17735d2). Report is 20 commits behind head on develop.

:exclamation: Current head 17735d2 differs from pull request most recent head 5b5547c. Consider uploading reports for the commit 5b5547c to get more accurate results

Files Patch % Lines
src/pandapipes/pf/derivative_calculation.py 91.89% 3 Missing :warning:
.../api/release_cycle/release_control_test_network.py 95.23% 3 Missing :warning:
src/pandapipes/converter/stanet/preparing_steps.py 50.00% 1 Missing :warning:
src/pandapipes/test/api/test_convert_format.py 94.11% 1 Missing :warning:
...st/stanet_comparison/pipeflow_stanet_comparison.py 50.00% 1 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## develop #597 +/- ## =========================================== + Coverage 90.49% 90.84% +0.35% =========================================== Files 139 139 Lines 10549 10996 +447 =========================================== + Hits 9546 9989 +443 - Misses 1003 1007 +4 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

dlohmeier commented 6 months ago

Codacy analysis: grafik

SimonRubenDrauz commented 6 months ago

Otherwise just a few small comments. I will think about the aspect of calling a property with just a float for another while... don't know if it should be allowed or not.

Great! If you come to a solution, let me know.

dlohmeier commented 6 months ago

I am very happy with MDOTINIT. I just thought that we should have something different than MINIT and came up with MF for mass flow.

Regarding the number of iterations: In many cases, the number of iterations increases if we use bad derivatives. In some cases, the NR might not even converge. Therefore an increased number of iterations is always a hint for errors in the derivative implementation. So I will double check these formulations. And having this information from the tests would be very helpful. Maybe it's even best if we do a test that ensures that a certain number of iterations for a given setup is not exceeded. It should not depend on the working environment. If this number is exceeded, the test fails and we know that we have to address this issue.

SimonRubenDrauz commented 6 months ago

I changed it now from MINIT to MDOTINIT!

SimonRubenDrauz commented 5 months ago

@dlohmeier, did you come up with a solution for calling a property with just a float?