Closed SimonRubenDrauz closed 5 months ago
Codacy analysis:
The best test for me is if the pipeflow is still converging. Additionally, I could check if the pit entries in the first iteration match (taking into account the m and v are connected by density and area). I would say I take the two release tests as reference.
Two tests were not converging as the number of iterations increased. However, the difference in the end were less than three iterations. But what I could do: For all tests I could save the number of iterations required for both m and v. Afterwards I would just compare both results.
What I do not get: What does f stand for. Actually I would say MDOTFINIT, but that might be too long. Maybe MDFINIT?
Otherwise just a few small comments. I will think about the aspect of calling a property with just a float for another while... don't know if it should be allowed or not.
Great! If you come to a solution, let me know.
I am very happy with MDOTINIT. I just thought that we should have something different than MINIT and came up with MF for mass flow.
Regarding the number of iterations: In many cases, the number of iterations increases if we use bad derivatives. In some cases, the NR might not even converge. Therefore an increased number of iterations is always a hint for errors in the derivative implementation. So I will double check these formulations. And having this information from the tests would be very helpful. Maybe it's even best if we do a test that ensures that a certain number of iterations for a given setup is not exceeded. It should not depend on the working environment. If this number is exceeded, the test fails and we know that we have to address this issue.
I changed it now from MINIT to MDOTINIT!
@dlohmeier, did you come up with a solution for calling a property with just a float?
Codecov Report
Attention: Patch coverage is
99.00881%
with9 lines
in your changes are missing coverage. Please review.Additional details and impacted files
```diff @@ Coverage Diff @@ ## develop #597 +/- ## =========================================== + Coverage 90.49% 90.84% +0.35% =========================================== Files 139 139 Lines 10549 10996 +447 =========================================== + Hits 9546 9989 +443 - Misses 1003 1007 +4 ```:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.