search

e2nIEE / pandapipes

A pipeflow calculation tool that complements pandapower in the simulation of multi energy grids
https://www.pandapipes.org
Other
139 stars 60 forks source link

renamed JAC_DERIV_DT1 to JAC_DERIV_DTOUT in branch_idx #598

Closed dlohmeier closed 5 months ago

dlohmeier commented 6 months ago

I think using TOUT here acknowledges that we are always using the pipe outlet temperature considering the flow direction, which is also been reflected by the naming of the corresponding variable TOUTINTIT.

dlohmeier commented 6 months ago

We might also change JAC_DERIV_DT to JAC_DERIV_DTIN, but this is not reflected by any other variable, as the temperature used here belongs to the node (so it could be called JAC_DERIV_DTNODE as well).

codecov[bot] commented 6 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

:exclamation: No coverage uploaded for pull request base (develop@3c78a13). Click here to learn what that means.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## develop #598 +/- ## ========================================== Coverage ? 90.49% ========================================== Files ? 139 Lines ? 10549 Branches ? 0 ========================================== Hits ? 9546 Misses ? 1003 Partials ? 0 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.