search

e2nIEE / pandapipes

A pipeflow calculation tool that complements pandapower in the simulation of multi energy grids
https://www.pandapipes.org
Other
139 stars 60 forks source link

Fix/numpy release #634

Closed mfranz13 closed 2 months ago

mfranz13 commented 2 months ago

Numpy released its 2.0.0 version on June 16th. The release contains some brekaing changes that are all described in the migration guide. A lot of members of the np. namespace have been deprecated, removed or moved. Most notably for us, they changed that previously capitalized variable names like np.NaN or np.Inf now consist entirely of lowercase letters.

dlohmeier commented 2 months ago

Thanks for making adjustments for new numpy releases. Can you provide a hint what has been changed and what is necessary to adapt?

mfranz13 commented 2 months ago

@dlohmeier I added a brief explanation in the description.

dlohmeier commented 2 months ago

Thanks for the description. What I find interesting is that they recommend ruff usage with the respective linting rule.

mfranz13 commented 2 months ago

I implemented the changes with ruff as they are describing it. Unfortunately i had to fix all imports of Inf myself because they did not get detected.

mfranz13 commented 2 months ago

FYI: Changes for pandapower are already on their way and should be released today or tomorrow

EPrade commented 2 months ago

Changes in pandapower have been merged on master. Now all checks are passing. Should we merge this PR?