search

e2nIEE / pandapower

Convenient Power System Modelling and Analysis based on PYPOWER and pandas
https://www.pandapower.org
Other
847 stars 478 forks source link

Several Asymmetric/Three Phase PF optional parameters not tested #1196

Open loshmee opened 3 years ago

loshmee commented 3 years ago

In the function call, various parameters are present but not tested

runpp_3pf

lthurner commented 3 years ago

The parameters that aren't used in pf_3ph should be deleted completely from the function.

Can you put in a Pull Request that deletes the marked paraameters from the runpp_3ph function? There is an explanation on how to contribute here: https://github.com/e2nIEE/pandapower/blob/develop/CONTRIBUTING.rst

elodin commented 2 years ago

@lthurner @gourab2009 @loshmee I will look into it and remove unused parameters.