e2nIEE / pandapower

Convenient Power System Modelling and Analysis based on PYPOWER and pandas
https://www.pandapower.org
Other
847 stars 478 forks source link

implementation of finding which elements belong to new grid equivalents should be more robust #1669

Open SteffenMeinecke opened 2 years ago

SteffenMeinecke commented 2 years ago

In the if clause of get_equivalent() new equivalent elements are collect to a group. This implementation is not as resistant as it could. It uses the naming convention of the internally used create functions. However, it is not checked whether this approach always works fine, e.g. if the input net has names like "..._separate". It is recommended to return the indices of the elements to allow creating a group with that, or to first create a group an then append new equivalent elements to that group.

ZhengLiu1119 commented 2 years ago