[bug] Failing power flow calculation if non mandatory attributes not set

AnkurArohi commented 2 weeks ago

Bug report checklis

[X] Searched the issues page for similar reports
[X] Read the relevant sections of the documentation
[X] Browse the tutorials and tests for usefull code snippets and examples of use
[X] Reproduced the issue after updating with pip install --upgrade pandapower (or git pull)
[X] Tried basic troubleshooting (if a bug/error) like restarting the interpreter and checking the pythonpath

Reproducible Example

Simply create a network and do not provide "tap_step_degree" for trafo dfand "shift_mv" and "shift_lv_degree" for trafo3w df. Try to run power flow , this results in error of missing shift_mv_degree exception.

Issue Description and Traceback

After setting PU gens as PQ gens in network, Load Flow did not converge: 'DataFrame' object has no attribute 'shift_mv_degree' dc powerflow did not work: 'DataFrame' object has no attribute 'shift_mv_degree'

Expected Behavior

Since these columns are not mandatory in the pandapower documentation for load flow calculation this should never occur

Installed Versions

python version: 3.12*

Label

[x] Relevant labels are selected

bott-j commented 4 days ago

@AnkurArohi, was this after changing to using static generators in the network model?

Did it fail both normal power flow and dc power flow, and do you have an example of the network being modelled?

AnkurArohi commented 4 days ago

Yes and it fails for both

bott-j commented 3 days ago

@AnkurArohi , I haven't been able to reproduce this.

Was create_transformer_from_parameters() and create_sgen() used to create the equipment in the network? What was the slack/reference bus for the model?

I'm assuming it was the latest version of pandapower?

AnkurArohi commented 3 days ago

Yes it was latest,slack and all other details were same and it works with the old pp version

e2nIEE / pandapower