search

e2nIEE / pandapower

Convenient Power System Modelling and Analysis based on PYPOWER and pandas
https://www.pandapower.org
Other
885 stars 485 forks source link

topology - Why does unsupplied_buses have a parameter in_service only? #357

Closed julffers closed 5 years ago

julffers commented 5 years ago

The topology function unsupplied_buses has a parameter "in_service_only". If True, unsupplied buses, that are out of service are removed from the returned result. Why does this paramter exist? If a pandapower net and no multigraph are passed to unsupplied buses, create_nx_graph creates a multigraph that does not contain out of service buses anyway.

Is there any reasonable case, where one would pass a net AND a multigraph that does not correctly represent the net and therefore, the out of service buses would have to be removed from the result?

lthurner commented 5 years ago

I remember @rbolgaryn requested this feature, but looking at it now I am also not sure why it exists. The implementation is also not very efficient with iterating over the buses and then indexing with .loc. Seems like a functionality that can be deprecated to me.

FlorianShepherd commented 5 years ago

Please removetthis feature @julffers