search

e2nIEE / pandapower

Convenient Power System Modelling and Analysis based on PYPOWER and pandas
https://www.pandapower.org
Other
885 stars 485 forks source link

simple_plotly doesn't plot network according to matrices #75

Closed mihagrabner closed 6 years ago

mihagrabner commented 7 years ago

Hi! I use Jupyter notebooks. The code below is from the website and it is supposed to plot the MV network. But when I run the code below the network that is plotted is not the same as the one that I wanted to plot (from the website). And also the network plotted with simple_plotly() does not correspond to the bus, line and trafos matrices. So the plotted network is not plotted as it is supposed to be. Please see the attached picture.

napaka_pp_1

net_mv = pn.create_cigre_network_mv(with_der=False) simple_plotly(net_mv)

jhmenke commented 7 years ago

The plot is correct, i suspect that only the labels are set incorrectly.

jhmenke commented 7 years ago

This was just a small bug with incorrectly ordered bus_geodata. It is fixed in commit f316742fc15f6162fc29c4d0aff9ad63ad963913

mihagrabner commented 7 years ago

I went to a link you provided me with, clicked on the view, copied all the code, save it and it still doesn't work.

So if I understand it right there is a problem with the network, not the plotting? So I expect it will work on the new network?

lthurner commented 7 years ago

You can install the current version from github by uninstall pandapower:

pip uninstall pandapower

And then installing the newest develop version of pandapower from github:

pip install git+https://github.com/lthurner/pandapower.git@develop

It will take a while to install because the repo is cloned into, but in the end you should have the newest version.

mihagrabner commented 7 years ago

I uninstalled it, then when I try to install it I get this:

Error [WinError 2] The system cannot find the file specified while executing command git clone -q https://github.com/lthurner/pandapower.git C:\Users\Miha\AppData\Local\Temp\pip-7s8t_zo7-build Cannot find command 'git'

lthurner commented 7 years ago

you have to install git: https://git-scm.com/

mihagrabner commented 7 years ago

I 've installed, buses are now OK but lines are still wrong. Switch table also doesn't correspond to the plot.

jhmenke commented 7 years ago

I checked it again and you are correct. Maybe the author @jkrstulo can identify the problem the fastest?

FlorianShepherd commented 6 years ago

The error is now fixed I assume. See https://github.com/lthurner/pandapower/commit/f14386ceccd21ae24a2e51962767aced7a8fd80e

@mihagibson would you confirm that, please?

Also note that the legend in simple_plotly is a little bit strange atm. We'll have a look into that soon.