e36freak / meat

30 stars 7 forks source link

Hey e36freak! I've made a few changes to the script and PKGBUILD and I was wondering if you approved of them? #1

Closed WildCryptoFox closed 13 years ago

WildCryptoFox commented 13 years ago

Just tell me over IRC what you think..

Added: -C|--nocolor to disable color output when unwanted.. ( configuration may say enabled, without this you had to edit that configuration file again, now it's just as easy as -C ) Added: ==> Installing $pkg..

Installs the configuration file to /usr/share/meat/config now.. ( before you had to manually get the file ) Also, maybe adding an after install note to say about the configuration file would be nice too..

e36freak commented 13 years ago

first commit: you didn't actually "add" anything, you just put it in the usage. I'm considering doing the standard --color={always,auto,never}, but not worried about that right away.

second: it's a versioned dep, it's staying, that's the end of it. i don't want anyone bitching due to an out of date mirror or something.

third: that's fine, it's going to be done, but the config file should be 0644, not 0755.

also, the other bug you mentioned has been fixed.

e36freak commented 13 years ago

oh, and as far as the "installing" message, i have a function for that. and it's been added.