search

e3nn / e3nn-jax

jax library for E3 Equivariant Neural Networks
Apache License 2.0
182 stars 18 forks source link

Gate output irreps #4

Closed jamaliki closed 3 years ago

jamaliki commented 3 years ago

From what I understand from here, we expect the output of the gate to be the direct sum of scalar irreps and gated irreps. But in e3nn_jax, it is the direct sum of scalar irreps, gated irreps, and gated irreps as well. I think the reason is the line below. Is this an issue? @mariogeiger

https://github.com/e3nn/e3nn-jax/blob/767e9bdfb99c68416612daffd1993cb5cf69fc1e/e3nn_jax/_gate.py#L76

mariogeiger commented 3 years ago

I am confused. Are you talking about the input or the output?

The is no difference between e3nn and e3nn_jax for the Gate: The input is https://github.com/e3nn/e3nn-jax/blob/767e9bdfb99c68416612daffd1993cb5cf69fc1e/e3nn_jax/_gate.py#L76

And the output is https://github.com/e3nn/e3nn-jax/blob/767e9bdfb99c68416612daffd1993cb5cf69fc1e/e3nn_jax/_gate.py#L87

jamaliki commented 3 years ago

Sorry, this was my misunderstanding