Mostly save_e61 changes

aaronw22 commented 9 months ago

Describe your changes

Restored (improved) png support that is based on creating an SVG first then saving it as PNG.
Moved a bunch of code that is duplicated across the two save functions into the main save function.
Removed the plots/plot distinction between multi and single function argument.
Tidied up args in the single/multi functions where the defaults are set in save_e61.
Fixed various tests for save_e61.
Feeding random non-ggplot objects is now an error condition rather than just a warning.
Restored the advisory messages, currently only checks for y-axis label compliance.
Controversial: Force the user to acknowledge the message by typing in Y/N to continue saving.

aaronw22 commented 9 months ago

Opinion requested on one of the changes @JackBuckley

aaronw22 commented 9 months ago

Only change is to limit the y-title rule to when y-title top is used.

Thanks for the feedback, now done.