Plots where `y` aes are not in `ggplot(aes())` do not show sec axis if `scale_y_continuous_e61` is not supplied

e61-Institute / theme61

Create graphs in the e61 Institute style

https://e61-institute.github.io/theme61/

MIT License

5 stars 0 forks source link

Open aaronw22 opened 7 months ago

JackBuckley commented 7 months ago

Potential solution

Add attribute to the plot when scale_y_continuous is run
If attribute exists when updating sclaes, then perform checks for second y-axis to ensure we don't override
If it doesn't exist, then don't perform the checks as the user hasn't actually provided that input

aaronw22 commented 7 months ago

Another bug:

If you have any y-transformations in aes it doesn't add scale_y_continuous_e61() internally either.

Example:

ggplot(sd_differential, aes(x = transaction_value / 1e3, 
                         y = 100 * value / transaction_value)) +
  geom_line()