search

eAndrius / BitfinexLendingBot

BitfinexLendingBot - A bot for automated lending at Bitfinex
Other
161 stars 60 forks source link

Strategy improvements #9

Closed ghost closed 8 years ago

ghost commented 8 years ago

See commit comments. Still needs more testing but I believe the idea is good. We may want new options for these and/or create a new strategy file?

ghost commented 8 years ago

Oops, I forgot to update with test findings. Should probably revert this PR. The ignoreFRR feature doesn't work that well in practice, at one point I did have great success with it but most of the time offers never get filled. Also, the 'place 1 point below competing offer' logic will probably cause bots to out-compete each other and race to a very low rate, if this bot is adopted by many users. I am no longer working on this bot at the moment as the rates are so low anyway.

The commit "Change loanOffers to a map so that multiple offers at the same rate are consolidated into one offer" should be uncontroversial, but there may be an easier way of achieving the same (this is literally my first time writing Go code, as you can probably tell). It's not a very important feature either, so probably the best thing to do is reverting the whole merge.