eBay / HomeObject

Replicated BLOB Store built upon HomeStore
Apache License 2.0
6 stars 15 forks source link

Adopt recovery order of HS metaservice #105

Closed JacksonYao287 closed 1 year ago

JacksonYao287 commented 1 year ago

since we add recover dependency logic in HS, this PR adopt this functionality and simplify the recover logic in homeobject

codecov-commenter commented 1 year ago

Codecov Report

Attention: 4 lines in your changes are missing coverage. Please review.

Comparison is base (3bf233a) 78.91% compared to head (5060ccf) 79.55%. Report is 1 commits behind head on main.

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #105 +/- ## ========================================== + Coverage 78.91% 79.55% +0.63% ========================================== Files 28 28 Lines 996 978 -18 Branches 95 89 -6 ========================================== - Hits 786 778 -8 + Misses 154 145 -9 + Partials 56 55 -1 ``` | [Files](https://app.codecov.io/gh/eBay/HomeObject/pull/105?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=eBay) | Coverage Δ | | |---|---|---| | [src/lib/homestore\_backend/hs\_blob\_manager.cpp](https://app.codecov.io/gh/eBay/HomeObject/pull/105?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=eBay#diff-c3JjL2xpYi9ob21lc3RvcmVfYmFja2VuZC9oc19ibG9iX21hbmFnZXIuY3Bw) | `74.79% <100.00%> (ø)` | | | [src/lib/homestore\_backend/hs\_homeobject.cpp](https://app.codecov.io/gh/eBay/HomeObject/pull/105?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=eBay#diff-c3JjL2xpYi9ob21lc3RvcmVfYmFja2VuZC9oc19ob21lb2JqZWN0LmNwcA==) | `91.52% <100.00%> (+4.02%)` | :arrow_up: | | [src/lib/homestore\_backend/hs\_homeobject.hpp](https://app.codecov.io/gh/eBay/HomeObject/pull/105?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=eBay#diff-c3JjL2xpYi9ob21lc3RvcmVfYmFja2VuZC9oc19ob21lb2JqZWN0LmhwcA==) | `63.63% <ø> (ø)` | | | [src/lib/memory\_backend/mem\_blob\_manager.cpp](https://app.codecov.io/gh/eBay/HomeObject/pull/105?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=eBay#diff-c3JjL2xpYi9tZW1vcnlfYmFja2VuZC9tZW1fYmxvYl9tYW5hZ2VyLmNwcA==) | `71.42% <100.00%> (+2.19%)` | :arrow_up: | | [src/lib/homestore\_backend/hs\_pg\_manager.cpp](https://app.codecov.io/gh/eBay/HomeObject/pull/105?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=eBay#diff-c3JjL2xpYi9ob21lc3RvcmVfYmFja2VuZC9oc19wZ19tYW5hZ2VyLmNwcA==) | `71.95% <66.66%> (+2.98%)` | :arrow_up: | | [src/lib/homestore\_backend/index\_kv.cpp](https://app.codecov.io/gh/eBay/HomeObject/pull/105?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=eBay#diff-c3JjL2xpYi9ob21lc3RvcmVfYmFja2VuZC9pbmRleF9rdi5jcHA=) | `73.68% <50.00%> (+0.95%)` | :arrow_up: |

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.