search

eBay / HomeObject

Replicated BLOB Store built upon HomeStore
Apache License 2.0
6 stars 15 forks source link

replicate createpg message across raft group #136

Closed JacksonYao287 closed 9 months ago

JacksonYao287 commented 10 months ago

we need to replicate create PG message across the rafte group, so that the follower can create pginfo and index table.

codecov-commenter commented 10 months ago

Codecov Report

Attention: 31 lines in your changes are missing coverage. Please review.

Comparison is base (c3a1459) 72.43% compared to head (fba3006) 72.23%.

Files Patch % Lines
src/lib/homestore_backend/hs_pg_manager.cpp 66.29% 23 Missing and 7 partials :warning:
src/include/homeobject/pg_manager.hpp 0.00% 1 Missing :warning:

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #136 +/- ## ========================================== - Coverage 72.43% 72.23% -0.21% ========================================== Files 30 30 Lines 1295 1390 +95 Branches 131 143 +12 ========================================== + Hits 938 1004 +66 - Misses 278 300 +22 - Partials 79 86 +7 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

JacksonYao287 commented 10 months ago

I have manually tested this PR with tree replicas. it works as expected!

@szmyd all the tests are passed in my local env, seem the CI failure is not caused by this PR itself, could you help taking a look?

JacksonYao287 commented 10 months ago

this PR can be successfully built after https://github.com/eBay/HomeStore/pull/284/files is merged