search

eBay / HomeObject

Replicated BLOB Store built upon HomeStore
Apache License 2.0
6 stars 15 forks source link

Add leader_id into error. #207

Closed xiaoxichen closed 2 months ago

raakella1 commented 2 months ago

The change makes sense to me.

codecov-commenter commented 2 months ago

:warning: Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 36.36364% with 28 lines in your changes missing coverage. Please review.

Project coverage is 69.20%. Comparing base (acb04e8) to head (ad791a3). Report is 15 commits behind head on main.

Files with missing lines Patch % Lines
src/lib/homestore_backend/hs_blob_manager.cpp 21.42% 20 Missing and 2 partials :warning:
src/lib/blob_manager.cpp 0.00% 0 Missing and 4 partials :warning:
src/include/homeobject/blob_manager.hpp 85.71% 1 Missing :warning:
src/lib/homestore_backend/index_kv.cpp 75.00% 1 Missing :warning:

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #207 +/- ## ========================================== + Coverage 68.69% 69.20% +0.51% ========================================== Files 30 30 Lines 1581 1552 -29 Branches 163 162 -1 ========================================== - Hits 1086 1074 -12 + Misses 408 389 -19 - Partials 87 89 +2 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.