search

eBay / HomeObject

Replicated BLOB Store built upon HomeStore
Apache License 2.0
6 stars 15 forks source link

raft test framework for homeobject #218

Closed JacksonYao287 closed 4 weeks ago

JacksonYao287 commented 1 month ago

1 add a raft test framework for homeobject , which will enable 3-replica raft-based test. 2 move all the current UT from single replica to 3 replicas raft-based 3 find and fix a blob sequence number bug after involving the new test framework.

codecov-commenter commented 1 month ago

:warning: Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 75.00000% with 1 line in your changes missing coverage. Please review.

Project coverage is 63.95%. Comparing base (acb04e8) to head (2490a3c). Report is 24 commits behind head on main.

Files with missing lines Patch % Lines
src/lib/homestore_backend/hs_blob_manager.cpp 50.00% 1 Missing :warning:

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #218 +/- ## ========================================== - Coverage 68.69% 63.95% -4.74% ========================================== Files 30 32 +2 Lines 1581 1784 +203 Branches 163 193 +30 ========================================== + Hits 1086 1141 +55 - Misses 408 546 +138 - Partials 87 97 +10 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

sanebay commented 4 weeks ago

Can you add another PR to add support for spare replicas. This is needed for PG move. https://github.com/eBay/HomeStore/blob/master/src/tests/test_common/hs_repl_test_common.hpp#L41

JacksonYao287 commented 4 weeks ago

Can you add another PR to add support for spare replicas. This is needed for PG move.

ok， will do

xiaoxichen commented 4 weeks ago

pls do a squash merge with some commit msg