search

eBay / HomeObject

Replicated BLOB Store built upon HomeStore
Apache License 2.0
6 stars 15 forks source link

fix create_snapshot #233

Closed Besroy closed 2 days ago

Besroy commented 3 days ago

m_snapshot_context is nullptr in the first create_snapshot, add check to avoid crash.

codecov-commenter commented 3 days ago

:warning: Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 0% with 5 lines in your changes missing coverage. Please review.

Project coverage is 64.09%. Comparing base (1746bcc) to head (d4751e3). Report is 5 commits behind head on main.

Files with missing lines Patch % Lines
...ib/homestore_backend/replication_state_machine.cpp 0.00% 5 Missing :warning:

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #233 +/- ## ========================================== + Coverage 63.15% 64.09% +0.93% ========================================== Files 32 32 Lines 1900 1972 +72 Branches 204 210 +6 ========================================== + Hits 1200 1264 +64 - Misses 600 603 +3 - Partials 100 105 +5 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.