search

eBay / HomeObject

Replicated BLOB Store built upon HomeStore
Apache License 2.0
6 stars 15 forks source link

Fix some bugs in baseline resync #236

Open yuwmao opened 19 hours ago

yuwmao commented 19 hours ago

This PR should be merged after https://github.com/eBay/HomeStore/pull/596

Add pg_size and chunk_size in the pg data mesg to avoid inconsistency.

koujl commented 18 hours ago

This PR should be merged after https://github.com/eBay/HomeStore/pull/596

Let's update the dependency constraint in conanfile.py to explicitly specify this homestore version requirement.

codecov-commenter commented 1 hour ago

:warning: Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 13.33333% with 26 lines in your changes missing coverage. Please review.

Please upload report for BASE (baseline_resync@2726477). Learn more about missing BASE report.

Files with missing lines Patch % Lines
...ib/homestore_backend/replication_state_machine.cpp 0.00% 26 Missing :warning:

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## baseline_resync #236 +/- ## ================================================== Coverage ? 65.60% ================================================== Files ? 33 Lines ? 2265 Branches ? 254 ================================================== Hits ? 1486 Misses ? 655 Partials ? 124 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.