codecov-commenter
commented
1 year ago Codecov Report
Attention: 17 lines in your changes are missing coverage. Please review.
Comparison is base (
aa65ee8) 79.69% compared to head (a55b80e) 79.09%.
| Files | Patch % | Lines |
|---|---|---|
| src/lib/homestore_backend/hs_shard_manager.cpp | 39.28% | 15 Missing and 2 partials :warning: |
:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.
Additional details and impacted files
```diff @@ Coverage Diff @@ ## main #98 +/- ## ========================================== - Coverage 79.69% 79.09% -0.60% ========================================== Files 29 29 Lines 1034 1057 +23 Branches 101 104 +3 ========================================== + Hits 824 836 +12 - Misses 149 159 +10 - Partials 61 62 +1 ```:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
there is a small chance that HO will be crashed before write metablk is completed in on_commit() for create/seal shard when associated journal log is already written(and been replicated to the majority of PG Members when we have real replication), in that case, we need to replay journal log to recover shard info after homeobject restarts