search

eBay / HomeStore

Storage Engine for block and key/value stores.
Apache License 2.0
23 stars 21 forks source link

Fix crash simulation #548

Closed shosseinimotlagh closed 2 months ago

shosseinimotlagh commented 2 months ago

The problem was in case of crash, either index service or wb cache can be nullptr during crash simulation while accessing in different code path. This will prevent accessing them while triggering crash simulator

codecov-commenter commented 2 months ago

:warning: Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 61.53846% with 5 lines in your changes missing coverage. Please review.

Project coverage is 67.59%. Comparing base (1a0cef8) to head (d63bd51). Report is 62 commits behind head on master.

Files with missing lines Patch % Lines
src/lib/index/wb_cache.cpp 50.00% 4 Missing :warning:
src/include/homestore/homestore.hpp 66.66% 1 Missing :warning:

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #548 +/- ## =========================================== + Coverage 56.51% 67.59% +11.08% =========================================== Files 108 109 +1 Lines 10300 10397 +97 Branches 1402 1400 -2 =========================================== + Hits 5821 7028 +1207 + Misses 3894 2697 -1197 - Partials 585 672 +87 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.