search

eBay / HomeStore

Storage Engine for block and key/value stores.
Apache License 2.0
23 stars 21 forks source link

Change replace member api signature. #570

Closed sanebay closed 1 month ago

sanebay commented 1 month ago

Changed the api signature because homeobject gets Member info with name, priority etc. But homestore api's dont have that. Add replica member info with name, priority and id. Use replica member info for replace member api and listener callbacks.

codecov-commenter commented 1 month ago

:warning: Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 55.55556% with 12 lines in your changes missing coverage. Please review.

Project coverage is 66.89%. Comparing base (1a0cef8) to head (6954fdd). Report is 79 commits behind head on master.

Files with missing lines Patch % Lines
src/lib/replication/repl_dev/raft_repl_dev.cpp 68.42% 6 Missing :warning:
src/lib/replication/service/raft_repl_service.cpp 16.66% 5 Missing :warning:
src/lib/replication/service/generic_repl_svc.cpp 0.00% 1 Missing :warning:

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #570 +/- ## =========================================== + Coverage 56.51% 66.89% +10.38% =========================================== Files 108 109 +1 Lines 10300 10586 +286 Branches 1402 1432 +30 =========================================== + Hits 5821 7082 +1261 + Misses 3894 2824 -1070 - Partials 585 680 +95 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.