search

eBay / HomeStore

Storage Engine for block and key/value stores.
Apache License 2.0
23 stars 21 forks source link

Add additional tests for replace member #574

Closed sanebay closed 3 weeks ago

sanebay commented 1 month ago

Add OneMemberRestart , LeaderReplace, OneMemberDown test case. Comments added in start of unit test

codecov-commenter commented 1 month ago

:warning: Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 0% with 4 lines in your changes missing coverage. Please review.

Project coverage is 63.71%. Comparing base (1a0cef8) to head (2ee5446). Report is 83 commits behind head on master.

Files with missing lines Patch % Lines
...rc/lib/replication/repl_dev/raft_state_machine.cpp 0.00% 4 Missing :warning:

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #574 +/- ## ========================================== + Coverage 56.51% 63.71% +7.20% ========================================== Files 108 109 +1 Lines 10300 10696 +396 Branches 1402 1468 +66 ========================================== + Hits 5821 6815 +994 + Misses 3894 3201 -693 - Partials 585 680 +95 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

xiaoxichen commented 3 weeks ago

i still dont think skipping wait_for_commit() on other leader is right....but as it is an UT, we can revisit if we see it flips.