Closed koujl closed 3 weeks ago
:warning: Please install the to ensure uploads and comments are reliably processed by Codecov.
Attention: Patch coverage is 85.71429%
with 5 lines
in your changes missing coverage. Please review.
Project coverage is 67.30%. Comparing base (
1a0cef8
) to head (76fc41a
). Report is 84 commits behind head on master.
:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Issue: https://github.com/eBay/HomeStore/issues/578
The
down_buf
has thereal_up_buf
(the meta buf) as its up_buffer, but cannot be found in theread_up_buf->m_down_buffers
. The inconsistency is caused by unprotected concurrent writes to the vectorm_down_buffers
.Add a mutex lock to
IndexBuffer
as well as extracting add/remove operations into member functions to make the vector thread-safe.