search

eBay / HomeStore

Storage Engine for block and key/value stores.
Apache License 2.0
23 stars 21 forks source link

Set min_log_gap_to_join to max_int32. #587

Closed xiaoxichen closed 2 weeks ago

codecov-commenter commented 2 weeks ago

:warning: Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 67.23%. Comparing base (1a0cef8) to head (0fb7a66). Report is 89 commits behind head on master.

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #587 +/- ## =========================================== + Coverage 56.51% 67.23% +10.72% =========================================== Files 108 109 +1 Lines 10300 10726 +426 Branches 1402 1465 +63 =========================================== + Hits 5821 7212 +1391 + Misses 3894 2819 -1075 - Partials 585 695 +110 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

JacksonYao287 commented 2 weeks ago

looks good, can you also set use_new_joiner_type_ to true in this PR?