Closed JacksonYao287 closed 1 day ago
:warning: Please install the to ensure uploads and comments are reliably processed by Codecov.
Attention: Patch coverage is 54.28571%
with 16 lines
in your changes missing coverage. Please review.
Project coverage is 66.60%. Comparing base (
1a0cef8
) to head (73bd8c2
). Report is 94 commits behind head on master.
:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
🚨 Try these New Features:
like
on_joining_cluster
,on_leaving_cluster
this is a good suggestion, will make this change
Then in this case, should we use https://github.com/eBay/NuRaft/blob/092997ab67eb2529c5b40556e1d301c8220c315d/include/libnuraft/callback.hxx#L95 and https://github.com/eBay/NuRaft/blob/092997ab67eb2529c5b40556e1d301c8220c315d/include/libnuraft/callback.hxx#L101
more callback type can be consumed from handle_raft_event
more callback type can be consumed from
handle_raft_event
1 in this PR , I only want to handle the leave cluster case. we can create another PR for join cluster case
2 RemovedFromCluster
callback will be called before the new configuration is applied , IMO, it is better to call it after the new configuration is applied, where we can guarantee the config changed is completed and the node is definitely removed from the cluster configuration
I hope the commits and commit message can be cleanup , there are two parts in this PR:
nuraft::cb_func::Type::RemovedFromCluster
callbackreset
function to allocator/vchunk as a preparation for implementing m_listener->on_destroy()
The pr title/commit messages are a bit confusing.
The pr title/commit messages are a bit confusing.
sure, will refine this commit message
in nuobject, when a member is moved out of a raft group, we should clear the pg related resource in the member , which will be done in the config change handler. this PR aims to add this interface, which is also helpful for other use case to reclaim their application layer resource