search

eBay / NuRaft

C++ implementation of Raft core logic as a replication library
Apache License 2.0
1.02k stars 240 forks source link

asio_service support stream mode #527

Closed ZZhongge closed 3 months ago

ZZhongge commented 3 months ago
  1. set TCP_NODELAY = true this can be set after the socket open. So we can't set it in constructor. (async_connect will open the socket)
  2. does the order of calling all the when_done matter when error occur? in write path when_done(error triggered) -> close_socket(in destructor) in read path close_socket(directly call) -> when_done(error triggered)
  3. keep the old path for all request if streammode = false

already addressed all the comment.

greensky00 commented 3 months ago

Also, can you add

  pull_request:
    branches:
      - master
      - streaming

into .github/workflow/cmake.yml? in order to trigger PR validation for this branch.