Fix ordering of different length literal strings. Fixes #8

eBay / akutan

A distributed knowledge graph store

Apache License 2.0

1.65k stars 107 forks source link

Fix ordering of different length literal strings. Fixes #8 #14

Closed superfell closed 5 years ago

superfell commented 5 years ago

This adds a 0x00 between the string and the trailing languageID for String KGObjects. This ensures that "Bob" and "Bob's House" are ordered correctly. Previously this would be wrong because "Bob" would be "Bob00000ID" and so would be sorted based on the first '0' after Bob.

ongardie-ebay commented 5 years ago

I'm going to close and reopen this to (hopefully) trigger a Travis CI build (since this PR was opened before Travis CI was set up).