eBay / akutan

A distributed knowledge graph store
Apache License 2.0
1.65k stars 107 forks source link

KGObjects encoding of strings needs a null terminator #8

Closed superfell closed 5 years ago

superfell commented 5 years ago

When a literal string is encoded into a KGObject value, there's a separator between the end of the string and the language ID, but as the separator is not 0x00 this throws off sorting. (for example "Bob" & "Bob's house" aren't ordered correctly). The separator should be changed to be a null instead. This separator is not used to determine the length of the string, so there's no escaping considerations to be concerned about.