search

eBay / ebay-font

A small utility to efficiently load custom web fonts
MIT License
175 stars 19 forks source link

Nonce attribute #33

Closed abiyasa closed 6 years ago

abiyasa commented 6 years ago

Another option in order to support CSP since the lasso-nonce solution did not work.

abiyasa commented 6 years ago

Sadly the tests on Travis failed due to headless Chrome 😞 :

Cannot start ChromeHeadless 0115/155529.224975:FATAL:zygote_host_impl_linux.cc(123)] No usable sandbox! Update your kernel or see https://chromium.googlesource.com/chromium/src/+/master/docs/linux_suid_sandbox_development.md for more information on developing with the SUID sandbox. If you want to live dangerously and need an immediate workaround, you can try using --no-sandbox.

Not really sure why but the test runs well on Mac OSX, also on fresh yarn install. Maybe it's related to this issue (https://github.com/Googlechrome/puppeteer/issues/290) ?

abiyasa commented 6 years ago

Hi @RajaRamu @senthilp , do you mind having a look into this PR?

The build failed due to headless Chrome problem on Travis, which can be solved by this https://github.com/eBay/ebay-font/pull/35. Ideally, that PR should be merged before this one in order to pass the build.

senthilp commented 6 years ago

@RajaRamu As we discussed, whenever time permits please do a local build of the PR and verify the changes. Once verified we will merge it.

RajaRamu commented 6 years ago

@abiyasa - Can you check why build is failing?

RajaRamu commented 6 years ago

test

RajaRamu commented 6 years ago

Merged the other PR. can you please rebase this PR

abiyasa commented 6 years ago

@RajaRamu Rebased!