search

eBay / ebay-font

A small utility to efficiently load custom web fonts
MIT License
175 stars 19 forks source link

chore: update ebay-font to work with marko 5 & webpack #50

Closed PrashantAshok closed 3 years ago

PrashantAshok commented 3 years ago

Webpack doesn't support browser.json - hence created a component-browser.js to run required js files.

~Upgraded eslint-config-ebay - it was complaining about component.js. After the upgrade, it complained about using var and arrow functions in other files. Suppressed them for now - since UglifyJs doesn't support ES6. Will send a follow-up PR to fix those.~

Update: Tested this in lasso app as well - works fine there.

Update 2: Reverted back the eslint change, to keep the PR small. Created an issue to upgrade eslint and replace UglifyJs with Terser. #51

PrashantAshok commented 3 years ago

Since most browser's support it, closing this PR for now.