search

eBay / ebay-oauth-nodejs-client

🔑 Generate an OAuth token that can be used to call the eBay Developer REST APIs.
https://ebay.github.io/ebay-oauth-nodejs-client/
Apache License 2.0
63 stars 29 forks source link

Support passing credentials via constructor #1

Closed pajaydev closed 4 years ago

pajaydev commented 4 years ago

Right now this library takes the filePath, it would be easy if we can able to pass the credentials through the constructor like below.

const ebayAuthToken = new EbayAuthToken({
    "clientId": "---Client Id---",
     "clientSecret": "--- client secret---",
     "devid": "-- dev id ---",
     "redirectUri": "-- redirect uri ---",
})
andrii33 commented 4 years ago

Yeah, that would be a good change. It's required for me to start using the lib. Since I need it for multiple ebay sellers.

andrii33 commented 4 years ago

You have already implemented it in the correct way here https://github.com/pajaydev/oauth-ebay/blob/master/example.js

pajaydev commented 4 years ago

@andrii33 We have moved the same repo under eBay org to make it official. Moving forward this will be the official one.

mattia85 commented 4 years ago

@andrii33 We have moved the same repo under eBay org to make it official. Moving forward this will be the official one.

really? when?