fix: added controlled logic for switch - Githubissues

eBay / ebayui-core-react

eBayUI React components

https://opensource.ebay.com/ebayui-core-react/main/

MIT License

28 stars 31 forks source link

fix: added controlled logic for switch #297

Closed maxrchung closed 10 months ago

maxrchung commented 10 months ago

This PR addresses https://github.com/eBay/ebayui-core-react/issues/296. It doesn't seem like I have permissions to directly link issue.

This change allows EbaySwitch to be controlled by checked prop.

Notes

Added similar isControlled logic from EbayCheckbox into EbaySwitch.
Added defaultChecked prop to follow logic from EbayCheckbox.

Testing

Added unit test to verify checkbox is not changed.
Added story that changes checked prop.

Demo

Showing issue before and updated stories after:

https://github.com/eBay/ebayui-core-react/assets/3955187/9d0658f3-1697-4d99-96c6-210b21b38c58

HenriqueLimas commented 10 months ago

We will consider as a patch version since it is aligning the behavior with other components, although it might break some application. We will work with the teams and make the proper changes.