Closed maxrchung closed 10 months ago
This PR addresses https://github.com/eBay/ebayui-core-react/issues/296. It doesn't seem like I have permissions to directly link issue.
This change allows EbaySwitch to be controlled by checked prop.
EbaySwitch
checked
isControlled
EbayCheckbox
defaultChecked
Showing issue before and updated stories after:
https://github.com/eBay/ebayui-core-react/assets/3955187/9d0658f3-1697-4d99-96c6-210b21b38c58
We will consider as a patch version since it is aligning the behavior with other components, although it might break some application. We will work with the teams and make the proper changes.
This PR addresses https://github.com/eBay/ebayui-core-react/issues/296. It doesn't seem like I have permissions to directly link issue.
This change allows
EbaySwitch
to be controlled bychecked
prop.Notes
isControlled
logic fromEbayCheckbox
intoEbaySwitch
.defaultChecked
prop to follow logic fromEbayCheckbox
.Testing
checked
prop.Demo
Showing issue before and updated stories after:
https://github.com/eBay/ebayui-core-react/assets/3955187/9d0658f3-1697-4d99-96c6-210b21b38c58