search

eBay / ebayui-core

Collection of Marko widgets; considered to be the core building blocks for all eBay components, pages & apps
https://ebay.github.io/ebayui-core/
Other
217 stars 102 forks source link

ebay-pagination: some page indexes are blue and some are black #139

Closed hramakumar closed 6 years ago

hramakumar commented 6 years ago

repro go to https://go/ebayui/test2 pagination indexes- some are blue and some are black. pls fix the discrepancy

sharma46bhawana commented 6 years ago

@ianmcburnie We see this issue because global header is adding a more specific style. What I can do is add more specificity to the achor tags but I wanted to avoid it if I could.

screen shot 2018-05-05 at 5 37 06 pm
sharma46bhawana commented 6 years ago

@hramakumar This is a skin issue, but I am not sure how to track it at correct place.

ianmcburnie commented 6 years ago

@sharma46bhawana Please paste the conflicting skin styles in here and we can decide what to do.

@hramakumar In addition to the URLs, please ensure to add screenshots in tickets. It makes things faster to triage and debug.

sharma46bhawana commented 6 years ago

Hi @ianmcburnie I am seeing these conflicting styles:

screen shot 2018-05-08 at 4 38 06 pm screen shot 2018-05-08 at 4 36 49 pm
sharma46bhawana commented 6 years ago

I can add :link pseudo selector that will make sure the correct color is rendered

ianmcburnie commented 6 years ago

Yep, let's go with that. You might need the :active and :visited too. Please copy the screenshot above into a new Skin issue and target the 4.1.0 release with your branch & PR (planned for a prerelease tomorrow, so we can sneak this in).

sharma46bhawana commented 6 years ago

@ianmcburnie Added the issue in the skin: https://github.com/eBay/skin/issues/188 Can this issue in ebayui-core be closed?

ianmcburnie commented 6 years ago

Yes, let's close this. It should be fixed in 4.0.0-1