Closed ianmcburnie closed 2 years ago
@ianmcburnie - couple of things:-
Perhaps make all strings required at compile time?
- Yes please, or at-least make a11y-*
attributes required?@PrashantAshok Great suggestions! We are having a brainstorming/planning session soon. I will make sure both of those are on the table.
I think 2 has been on the backlog long enough and I'm really hoping we can take it on at last!
One more - can we start thinking about "molecule" components, like "date-picker", "rich-text-editor"? Can be created from scratch or maybe include [internal] components.
ebay-menu-button: Make default variant to be button
and not form
.
We might want to change originalEvent
to be the first argument and have additional arguments as second argument.
That way it's more in line with HTML (instead of passing an object, which I think was due to limitations in marko 3)
Like:
<ebay-button on-click((originalEvent) => console.log(originalEvent))/>
<ebay-textbox on-input-change((originalEvent, value) => console.log(originalEvent, value))/>
Can we please look into adding in support for overlapping dialogs - lightbox over lightbox or lightbox over fullscreen dialog, etc.?
@PrashantAshok That would go against best practices, which the design system has now codified in their new "Levels of interaction framework" - I encourage you to take a look at that for how we can and should avoid visually overlapping modals.
Closing issue, will create a new one with v10
Done:
eBay-button: rename a11yButtonText to a11yLoadingText ebay-carousel: refactor status/headings API https://github.com/eBay/ebayui-core/issues/1630 ebay-details, remove p tag as the default, which is creating problems as teams are nesting block level elements inside of it carousel, rename a11y-heading-tag to a11y-heading-level ebay-menu-button: Make default variant to be button and not form.
Candidates for v9 breaking changes.
NOTE: we would not want to do ALL of these in one release. To make upgrades as painless as possible we should prioritise these.
Definites:
a11yButtonText
toa11yLoadingText
Maybes:
Other