eBay / ebayui-core

Collection of Marko widgets; considered to be the core building blocks for all eBay components, pages & apps
https://ebay.github.io/ebayui-core/
Other
215 stars 97 forks source link

menu-button: keyboard focus indicator disappears on menu items (Safari) #1720

Closed ianmcburnie closed 6 hours ago

ianmcburnie commented 2 years ago

Bug Report

eBayUI Version: 9.1.x

Description

On Safari (v15.6), the keyboard focus indicator disappears when navigating menu items with arrow keys.

https://opensource.ebay.com/ebayui-core/?path=/story/buttons-ebay-filter-menu-button--standard&args=type:radio https://opensource.ebay.com/ebayui-core/?path=/story/buttons-ebay-menu-button--standard

Workaround

None.

saiponnada commented 1 year ago

Waiting for the make-up changes to see if this issue will be fixed automatically. Currently no focus issue on skin & safari.

ianmcburnie commented 1 year ago

Waiting for the make-up changes to see if this issue will be fixed automatically. Currently no focus issue on skin & safari.

This doesn't appear to be a makeup related issue. Makeup menu-button is working fine for me.

saiponnada commented 1 year ago

Back then we decided to push this for a while to wait for the makeup changes and see if those changes will fix this. I do not see any issue currently with filter-menu-buttons in v16.3. Not sure how it got fixed either. This issue still persists with menu-button. Will investigate and look in to it again.

saiponnada commented 1 year ago

@ianmcburnie, Its working as expected in storybook sandbox mode and also on skin. Not really sure why its failing in controls mode. Weird I haven't noticed any styles being overridden.

saiponnada commented 1 year ago

As discussed, removing the priority for now as this is working in sandboxed mode.

agliga commented 6 hours ago

Closing for now, seems to be working.