refactor(phone-input): use Intl for country names instead of hardcoding - Githubissues

eBay / ebayui-core

Collection of Marko widgets; considered to be the core building blocks for all eBay components, pages & apps

https://ebay.github.io/ebayui-core/

Other

212 stars 97 forks source link

refactor(phone-input): use Intl for country names instead of hardcoding #2193

Closed LuLaValva closed 1 week ago

LuLaValva commented 2 weeks ago

Description

With current phone-input, we require bundle to include a list of all country names in a given locale. This is unnecessary because Intl already provides this functionality.

Context

A team was unable to make backend changes to get a list of country names, and I realized that they really shouldn't have to because we can use the browser for this instead

Note

Previously, it was possible to refrain from including certain countries from the list. This is no longer possible, but I think that is a good change. We should support all country codes.

Screenshots

References

https://github.com/eBay/ebayui-core/issues/2197

changeset-bot[bot] commented 2 weeks ago

🦋 Changeset detected

Latest commit: b45cdaefa084d78f0c82863c357cf046750392f0

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package

| Name | Type | | ----------------- | ----- | | @ebay/ebayui-core | Major |

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR