search

eBay / ebayui-core

Collection of Marko widgets; considered to be the core building blocks for all eBay components, pages & apps
https://ebay.github.io/ebayui-core/
Other
224 stars 104 forks source link

fix(combobox): remove role-description attribute #2301

Closed saiponnada closed 1 month ago

saiponnada commented 1 month ago

Description

Fixes #2245

Context

Previously, screen reader JAWS was inconsistent in announcing the role for combobox. So aria-roledescription was used as a fallback to provide clarity. aria-roledescription overrides how AT expresses the role.

Now that most of the AT consistently identify this role='combobox', we can safely remove the attribute aria-roledescription

changeset-bot[bot] commented 1 month ago

🦋 Changeset detected

Latest commit: 597bd8799d9b87070db6d56971a8c1179d0a6f35

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package | Name | Type | | ----------------- | ----- | | @ebay/ebayui-core | Minor |

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR