eBay / ebayui-core

Collection of Marko widgets; considered to be the core building blocks for all eBay components, pages & apps
https://ebay.github.io/ebayui-core/
Other
224 stars 104 forks source link

fix: add locale for ebay-video controls/buttons #2324

Closed UDAY556 closed 2 weeks ago

UDAY556 commented 2 weeks ago

Description

Added localization for ebay-video component

Context

https://github.com/eBay/ebayui-core/issues/2323

References

This change was requested form the accessibility team STRFRNT-5398 and STRFRNT-5391

Screenshots

Thumbnail play button

image

Video play arrow

image

Volume up button

image

Report button

image

Fullscreen

image

Seekbar

image
changeset-bot[bot] commented 2 weeks ago

🦋 Changeset detected

Latest commit: 4680ef7d9d7f74f5e34544088e06593dbbf9fde1

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package | Name | Type | | ----------------- | ----- | | @ebay/ebayui-core | Patch |

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

LuLaValva commented 2 weeks ago

Looks great! Can you add a changeset with npm run change and choose "patch"?

UDAY556 commented 2 weeks ago

@LuLaValva seems like CI build has failed, could you please take a look

LuLaValva commented 2 weeks ago

@LuLaValva seems like CI build has failed, could you please take a look

Ah, that's just because it fails for external contributors right now 😓. It should be good regardless. Once @agliga approves we'll merge.