search

eBay / ebayui-core

Collection of Marko widgets; considered to be the core building blocks for all eBay components, pages & apps
https://ebay.github.io/ebayui-core/
Other
217 stars 103 forks source link

button: disabled buttons shading is light - looks confusing with other secondary buttons #380

Closed hramakumar closed 6 years ago

hramakumar commented 6 years ago

Bug Report

eBayUI Version: 1.0.0

Description

disabled buttons are lighter in shade when compared to secondary buttons. in design docs https://ebay.github.io/skin/#button disabled buttons have darker shades

actual: button_disabled

expected: expected_disabled

Workaround

seangates commented 6 years ago

Doing a quick comparison ...

Using the DS4 site for buttons: image

Using the eBayUI demo site: image

Your test page: image

They look the same to me.

seangates commented 6 years ago

I see, you took this from the existing Skin site. Let me have a look.

hramakumar commented 6 years ago

verified