eBay / ebayui-core

Collection of Marko widgets; considered to be the core building blocks for all eBay components, pages & apps
https://ebay.github.io/ebayui-core/
Other
224 stars 104 forks source link

Combobox-readonly: duplicated attributes in both span and input #706

Closed cynthiahhc closed 5 years ago

cynthiahhc commented 5 years ago

Bug Report

eBayUI Version: 2.5.0

Description

After entering the id as an attribute into ebay-combobox-readonly, the id shows up in both span and input which should only shows up in `input.

  id:scoped="field"
  name=input.name
  multiline=(input.maxLength > 100)
  fluid=input.fluid
  value=input.value
  on-textbox-change('emit', 'textbox-change')
  on-textbox-input('emit', 'textbox-input')
  on-textbox-focus('emit', 'textbox-focus')
  on-textbox-blur('emit', 'textbox-blur')
  on-textbox-keydown('emit', 'textbox-keydown') />  

Screen Shot 2019-06-11 at 12 23 04

https://github.com/eBay/ebayui-core/blob/master/src/components/ebay-combobox-readonly/template.marko#L4

Workaround

It should be something similar to ebay-combobx https://github.com/eBay/ebayui-core/blob/master/src/components/ebay-combobox/template.marko#L36

ianmcburnie commented 5 years ago

Thanks for reporting this!

ianmcburnie commented 5 years ago

App team moved over to ebay-listbox, reducing this to P4.

ianmcburnie commented 5 years ago

Closing as wont fix, given this is a hidden/deprecated component.