search

eBay / ebayui-core

Collection of Marko widgets; considered to be the core building blocks for all eBay components, pages & apps
https://ebay.github.io/ebayui-core/
Other
217 stars 102 forks source link

Listbox: rename to ebay-listbox-button #726

Closed ianmcburnie closed 5 years ago

ianmcburnie commented 5 years ago

As a segway to v4, let's rename the current ebay-listbox to ebay-listbox-button. API will remain unchanged in this version and listbox will still be coupled to button.

In v4 we will completely separate the menu from the button #690

Doing it like this means we get to Markov4 quicker, but can go back and add an ebay-listbox to CoreUI v3.1 if it is asked for.

DylanPiercey commented 5 years ago

@ianmcburnie I think it might be worth writing an auto migration for this.

ianmcburnie commented 5 years ago

Good idea. That would be a good practice for us to get into with CoreUI.

ianmcburnie commented 5 years ago

Changes merged to 2.8.0 branch. Closing.