eBay / ebayui-core

Collection of Marko widgets; considered to be the core building blocks for all eBay components, pages & apps

https://ebay.github.io/ebayui-core/

Other

217 stars 103 forks source link

ebay-button: variable not resolved correctly #860

Closed cynthiahhc closed 5 years ago

cynthiahhc commented 5 years ago

Bug Report

eBayUI Version: 4.0.0

Description

It does not resolve to the correct baseClass and size https://github.com/eBay/ebayui-core/blob/master/src/components/ebay-button/template.marko#L13

Screenshots

Screen Shot 2019-09-09 at 11 59 48

msendlakowski commented 5 years ago

@cynthiahhc Can you tell me what version of Marko you're using?

cynthiahhc commented 5 years ago

I'm using marko@4.12.3.

DylanPiercey commented 5 years ago

@cynthiahhc when using legacy Marko v3 components (like eBay-ui) it is best to make sure that you are on the latest version of Marko 4 for the best compatibility. Is there anything preventing you from upgrading to the latest version of Marko?

msendlakowski commented 5 years ago

@cynthiahhc Can you try what Dylan suggested, and upgrading your version of Marko, to see if this is still a problem.

ianmcburnie commented 5 years ago

Closing due to lack of information/follow-up.