eBay / ebayui-core

Collection of Marko widgets; considered to be the core building blocks for all eBay components, pages & apps
https://ebay.github.io/ebayui-core/
Other
217 stars 102 forks source link

Percy: integrate visual regression testing on storybook stories #932

Open ianmcburnie opened 4 years ago

ianmcburnie commented 4 years ago

Now that we have component examples in isolated URLs, courtesy of storybook, we can begin integrating Percy into our workflow.

More details to follow.

https://percy.io

agliga commented 3 weeks ago

Will use chromatic for this probably.

ianmcburnie commented 3 weeks ago

Or visual-html? I guess Chromatic buys us the Figma integration though. I wonder if we could leverage visual-html for the majority of smoke tests, which would be efficient from a cost perspective.

DylanPiercey commented 3 weeks ago

One thing to note is that to adopt snapshot testing (which visual-html works best with) we'll need to move ebayui off of @marko/test and to vitest, jest, or similar.