search

eBay / eslint-config-ebay

MIT License
14 stars 11 forks source link

Update ecmaVersion to latest for optional chaining #23

Closed kailin0512 closed 4 months ago

DylanPiercey commented 5 months ago

@kailin0512 this config doesn't reflect what we recommended internally. Should we deprecate this? If not at the very least we should use "latest" instead of "2022" so that you don't need to make this PR every year 😅

kailin0512 commented 5 months ago

@kailin0512 this config doesn't reflect what we recommended internally. Should we deprecate this? If not at the very least we should use "latest" instead of "2022" so that you don't need to make this PR every year 😅

@DylanPiercey I updated to latest which should be the default value. Initially I thought we override this to 2017 for some specific reason but if you think always pull the latest should be fine we can do that as well. I was just encounter the optional chaining problem so I updated to minimum supported version.

I am ok to deprecate this as well but when did we decide not to recommend that internally? At least for couple platform modules and sample service it is still extending this module.

ianmcburnie commented 4 months ago

Will merge. Then I will bump the package version (new minor version), commit that change and publish to NPM.