eBay / flutter_glove_box

Various eBay tools for Flutter development
BSD 3-Clause "New" or "Revised" License
317 stars 62 forks source link

Adjust the default surfaceSize to be more indicative of a normal device #14

Open coreysprague opened 4 years ago

coreysprague commented 4 years ago

WidgetTester defaults to a 800x600 surface size (at 3.0 DPI). We could consider defaulting our golden tests to a more reasonable default (perhaps the dimensions of an iPhone X or Pixel 3). Additionally, consider dropping the DPI to 1.0 in order to speed up the tests.

tsimbalar commented 3 years ago

What would also be helpful (and maybe less breaking) would be to be able to define the default surface area in GoldenToolkitConfiguration once and for all, so we don't have to explicitly set it in every single test when we want to override it.

This would mean :

I believe a similar approach is currently used for the devices ?

fatherOfLegends commented 3 years ago

@tsimbalar I think this is a great idea.