search

eBay / flutter_glove_box

Various eBay tools for Flutter development
BSD 3-Clause "New" or "Revised" License
323 stars 69 forks source link

Add support for `variant` #179

Open nilsreichardt opened 1 year ago

nilsreichardt commented 1 year ago

The testWidgets method allows specifying variant parameter. This is helpful when you have different design for different platforms.

NickalasB commented 1 year ago

HI @nilsreichardt. That doesn't seem like too crazy of a change. Would you be interested in opening up a PR to add the variant param to the testGoldens function?

nilsreichardt commented 1 year ago

There is already an open PR. But the author seems to be inactive. Should I create a new PR or write a comment under the PR?

NickalasB commented 1 year ago

Yeah I think making a new PR that is limited to just adding the variant param would be easiest honestly