[golden_toolkit] Golden tests are failing after upgrading Flutter SDK to `v3.19.4` because fonts are allocating slightly more space

eBay / flutter_glove_box

Various eBay tools for Flutter development

BSD 3-Clause "New" or "Revised" License

319 stars 68 forks source link

[golden_toolkit] Golden tests are failing after upgrading Flutter SDK to `v3.19.4` because fonts are allocating slightly more space #190

Open yasinarik-talabat opened 6 months ago

yasinarik-talabat commented 6 months ago

Description of the Problem:

Golden tests are failing after upgrading Flutter SDK to v3.19.4 because fonts are allocating slightly more space.
As you can see in the diff image below, since the new fonts are taking more vertical space (height seems to be changed), everything misaligned vertically. Since this is a list of texts, the misalignment is staggered (cumulative), adding the one above and so on.

How to resolve this issue?

brennan-smith commented 5 months ago

We're running into the exact same issue. Wondering if you found any workaround or if there was an update on this issue?

ricardoboss commented 1 month ago

Are you sure this is related to the toolkit and not Flutter increasing font rendering fidelity?

brennan-smith commented 1 month ago

If it was just due to Flutter increasing the fidelity I would expect to see similar things in my actual applications, but it's only occurring in the golden_toolkit.